Re: [PATCH v6 0/4] Rewrite jevents program in python
From: Ian Rogers
Date: Wed Jun 29 2022 - 12:49:10 EST
On Mon, Jun 27, 2022 at 10:27 AM John Garry <john.garry@xxxxxxxxxx> wrote:
>
> On 27/06/2022 03:57, Ian Rogers wrote:
> > A challenge with this code is in avoiding regressions. For this reason
> > the jevents.py produces identical output to jevents.c, validated with a
> > test script and build target.
> >
> > v6. Adds Tested-by from Zhengjun Xing<zhengjun.xing@xxxxxxxxxxxxxxx>
> > and Thomas Richter<tmricht@xxxxxxxxxxxxx>. Fixes issues spotted
> > by Jiri Olsa<jolsa@xxxxxxxxxx>, jsmn.c wasn't deleted and the
> > empty pmu-events.c didn't pass the pmu-events test. It also adds a
> > missing mkdir which is necessary before creating pmu-events.c and
> > tweaks the quiet display code in the empty case to display a gen.
> > v5. Adds a 2>/dev/null as suggested by David Laight
>
>
> Hmmm... shouldn't this be v7? Anyway what I got with message-id
> 20220627025744.106527-1-irogers@xxxxxxxxxx now seems to build and the
> output looks ok.
>
> Thanks,
> John
Thanks John, I think I've confused myself by working on greater than 1
machine wrt version numbers. I can re-send as v7, would it be okay to
put on a Tested-by: John Garry <john.garry@xxxxxxxxxx> ?
Ian