Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done

From: Andy Lutomirski
Date: Mon Jul 11 2022 - 18:50:32 EST

On 7/10/22 16:33, Nadav Amit wrote:
From: Nadav Amit <namit@xxxxxxxxxx>

Currently, if flush_tlb_func() does not flush for some reason, the
tracing of the flush will be done only in certain cases, depending on
the reason of the flush. Be consistent and just do not trace in all
cases when the flush was eventually not done.

Suggested-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxx>
Signed-off-by: Nadav Amit <namit@xxxxxxxxxx>

Can you remove this comment, too?

/* Tracing is done in a unified manner to reduce the code size */

trace_tlb_flush(!local ? TLB_REMOTE_SHOOTDOWN :