Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done
From: Nadav Amit
Date: Mon Jul 11 2022 - 19:42:28 EST
On Jul 11, 2022, at 3:50 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> On 7/10/22 16:33, Nadav Amit wrote:
>> From: Nadav Amit <namit@xxxxxxxxxx>
>> Currently, if flush_tlb_func() does not flush for some reason, the
>> tracing of the flush will be done only in certain cases, depending on
>> the reason of the flush. Be consistent and just do not trace in all
>> cases when the flush was eventually not done.
>> Suggested-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>> Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
>> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
>> Signed-off-by: Nadav Amit <namit@xxxxxxxxxx>
> Can you remove this comment, too?
>> /* Tracing is done in a unified manner to reduce the code size */
Yes. I will send v2.
… And if you have time, can you please review the other TLB patch that I
sent? It is a really urgent one.