Re: [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to_timespec64()
From: Arnd Bergmann
Date: Tue Jul 12 2022 - 03:42:16 EST
On Tue, Jul 12, 2022 at 9:47 AM Youngmin Nam <youngmin.nam@xxxxxxxxxxx> wrote:
> As mentioned below,
> The "const" keyword is useless, so we drop it from the function definition and declaration.
> Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> Signed-off-by: Youngmin Nam <youngmin.nam@xxxxxxxxxxx>
The patch looks good, but the description can be improved:
- drop the useless Change-Id field
- move the URL into a 'Link: field'
- wrap the lines to fit into the normal width of an email (under 80 characters,
- explain why the change helps, rather than just stating the keyword is useless.
In your description, it's not clear if one is better than the other, it sounds
like it should make no difference.
With that done:
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>