RE: [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to_timespec64()
From: Chanho Park
Date: Tue Jul 12 2022 - 03:50:02 EST
> > As mentioned below,
I'm not sure why you drop my originality but please use my commit message and put this link between --- and include/linux/time32.h if you need additional comments.
Indeed you should put Fixes tag for stable tree.
> > The "const" keyword is useless, so we drop it from the function
> definition and declaration.
> > Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> > Signed-off-by: Youngmin Nam <youngmin.nam@xxxxxxxxxxx>
> The patch looks good, but the description can be improved:
> - drop the useless Change-Id field
> - move the URL into a 'Link: field'
> - wrap the lines to fit into the normal width of an email (under 80
> ideally 70)
> - explain why the change helps, rather than just stating the keyword is
> In your description, it's not clear if one is better than the other, it
> like it should make no difference.
> With that done:
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>