Re: [PATCH v4 8/9] iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled

From: Joerg Roedel
Date: Fri Jul 15 2022 - 04:46:13 EST


On Wed, Jul 13, 2022 at 05:56:50PM -0500, Suravee Suthikulpanit wrote:
> + /*
> + * Since DTE[Mode]=0 is prohibited on SNP-enabled system,
> + * default to use IOMMU_DOMAIN_DMA[_FQ].
> + */
> + if (WARN_ONCE(amd_iommu_snp_en && (type == IOMMU_DOMAIN_IDENTITY),
> + "Cannot allocate identity domain due to SNP\n"))

I removed that WARN_ON_ONCE() here, this is really no condition someone
should worry about.

Regards,

Joerg