Re: [PATCH v2 0/2] drm: A couple of fixes for drm_copy_field() helper function

From: Javier Martinez Canillas
Date: Fri Jul 15 2022 - 04:47:07 EST


On 7/5/22 12:02, Javier Martinez Canillas wrote:
> Hello,
>
> Peter Robinson reported me a kernel bug in one of his aarch64 test boards
> and even though I was not able to reproduce it, I think that figured out
> what the problem was. It seems the cause is that a DRM driver doesn't set
> some of the struct drm fields copied to userspace via DRM_IOCTL_VERSION.
>
> Even though this is a driver bug, we can make drm_copy_field() more robust
> and warn about it instead of leading to an attempt to copy a NULL pointer.
>
> While looking at this, I also found that a variable in drm_copy_field() is
> not using the correct type. So I included that change in the patch-set too.
>

Pushed these to drm-misc (drm-misc-next). Thanks!

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat