Re: [PATCH net-next] tcp: fix condition for increasing pingpong count

From: Jakub Kicinski
Date: Tue Jul 19 2022 - 20:49:25 EST


On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote:
> - if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) &&
> + if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) &&

Are you sure you don't need to take care of the values wrapping?
before() does that. You may want !after() if you want to allow equal.