Re: [PATCH net-next] tcp: fix condition for increasing pingpong count

From: LemmyHuang
Date: Wed Jul 20 2022 - 02:48:09 EST


At 2022-07-20 08:49:15, "Jakub Kicinski" <kuba@xxxxxxxxxx> wrote:
> On Tue, 19 Jul 2022 21:01:37 +0800 LemmyHuang wrote:
>> - if (before(tp->lsndtime, icsk->icsk_ack.lrcvtime) &&
>> + if ((tp->lsndtime <= icsk->icsk_ack.lrcvtime) &&
>
> Are you sure you don't need to take care of the values wrapping?
> before() does that. You may want !after() if you want to allow equal.

Yeap, I will switch to that in v2.
Thank you!