RE: [PATCH net-next v3 37/47] soc: fsl: qbman: Add CGR update function

From: Camelia Alexandra Groza
Date: Thu Jul 21 2022 - 09:18:35 EST


> -----Original Message-----
> From: Linuxppc-dev <linuxppc-dev-
> bounces+camelia.groza=nxp.com@xxxxxxxxxxxxxxxx> On Behalf Of Sean
> Anderson
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx
> Cc: Leo Li <leoyang.li@xxxxxxx>; Sean Anderson
> <sean.anderson@xxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH net-next v3 37/47] soc: fsl: qbman: Add CGR update
> function
>
> This adds a function to update a CGR with new parameters.
> qman_cgr_create can almost be used for this (with flags=0), but it's not

It's qman_create_cgr, not qman_cgr_create.

> suitable because it also registers the callback function. The _safe
> variant was modeled off of qman_cgr_delete_safe. However, we handle
> multiple arguments and a return value.
>
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>

Acked-by: Camelia Groza <camelia.groza@xxxxxxx>