RE: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate change

[Camelia Alexandra Groza]

> -----Original Message-----
> From: Linuxppc-dev <linuxppc-dev-
> bounces+camelia.groza=nxp.com@xxxxxxxxxxxxxxxx> On Behalf Of Sean
> Anderson
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx
> Cc: Leo Li <leoyang.li@xxxxxxx>; Sean Anderson
> <sean.anderson@xxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH net-next v3 38/47] net: dpaa: Adjust queue depth on rate
> change
> 
> Instead of setting the queue depth once during probe, adjust it on the
> fly whenever we configure the link. This is a bit unusal, since usually
> the DPAA driver calls into the FMAN driver, but here we do the opposite.
> We need to add a netdev to struct mac_device for this, but it will soon
> live in the phylink config.
> 
> I haven't tested this extensively, but it doesn't seem to break
> anything. We could possibly optimize this a bit by keeping track of the
> last rate, but for now we just update every time. 10GEC probably doesn't
> need to call into this at all, but I've added it for consistency.
> 
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>

Acked-by: Camelia Groza <camelia.groza@xxxxxxx>