Re: [PATCH net-next v3 20/47] net: fman: Store initialization function in match data

[Sean Anderson]

On 7/21/22 8:51 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@xxxxxxxx>
>> Sent: Saturday, July 16, 2022 0:59
>> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
>> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
>> netdev@xxxxxxxxxxxxxxx
>> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
>> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
>> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean Anderson
>> <sean.anderson@xxxxxxxx>
>> Subject: [PATCH net-next v3 20/47] net: fman: Store initialization function in
>> match data
>> 
>> Instead of re-matching the compatible string in order to determine the
>> init function, just store it in the match data. This also move the setting
>> of the rest of the functions into init as well. 
> 
> This last sentence can be rephrased to be clearer. Maybe something like:
> The separate setup functions aren't needed anymore. Merge their content
> into init as well.

You're right, this is not really clear. I will revise the wording.

--Sean

>> To ensure everything
>> compiles correctly, we move them to the bottom of the file.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> 
> Acked-by: Camelia Groza <camelia.groza@xxxxxxx>
>