Re: [PATCH net-next v3 29/47] net: fman: Map the base address once

From: Sean Anderson
Date: Thu Jul 21 2022 - 11:35:12 EST




On 7/21/22 9:04 AM, Camelia Alexandra Groza wrote:
>> -----Original Message-----
>> From: Sean Anderson <sean.anderson@xxxxxxxx>
>> Sent: Saturday, July 16, 2022 1:00
>> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
>> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
>> netdev@xxxxxxxxxxxxxxx
>> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
>> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
>> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean Anderson
>> <sean.anderson@xxxxxxxx>
>> Subject: [PATCH net-next v3 29/47] net: fman: Map the base address once
>>
>> We don't need to remap the base address from the resource twice (once in
>> mac_probe() and again in set_fman_mac_params()). We still need the
>> resource to get the end address, but we can use a single function call
>> to get both at once.
>>
>> While we're at it, use platform_get_mem_or_io and
>> devm_request_resource
>> to map the resource. I think this is the more "correct" way to do things
>> here, since we use the pdev resource, instead of creating a new one.
>> It's still a bit tricy, since we need to ensure that the resource is a
>
> *tricky* typo

Thanks, will fix.

--Sean

>> child of the fman region when it gets requested.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
>
> Acked-by: Camelia Groza <camelia.groza@xxxxxxx>
>