Re: [PATCH v2 2/3] dt-bindings: clock: add SM6375 QCOM global clock bindings

From: Krzysztof Kozlowski
Date: Thu Jul 21 2022 - 12:40:58 EST


On 20/07/2022 21:36, Konrad Dybcio wrote:
>
>
> On 20.07.2022 08:27, Krzysztof Kozlowski wrote:
>> On 19/07/2022 13:57, Konrad Dybcio wrote:
>>> Add device tree bindings for global clock controller for SM6375 SoCs.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>>> ---
>>> Changes since v1:
>>> - dropped clock-names (switched to .index)
>>>
>>> .../bindings/clock/qcom,sm6375-gcc.yaml | 65 +++++
>>> include/dt-bindings/clock/qcom,sm6375-gcc.h | 234 ++++++++++++++++++
>>> 2 files changed, 299 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>> create mode 100644 include/dt-bindings/clock/qcom,sm6375-gcc.h
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>> new file mode 100644
>>> index 000000000000..2e43cd75d3d4
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-gcc.yaml
>>> @@ -0,0 +1,65 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-gcc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Qualcomm Global Clock & Reset Controller Binding for SM6375
>>> +
>>> +maintainers:
>>> + - Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
>>> +
>>> +description: |
>>> + Qualcomm global clock control module which supports the clocks, resets and
>>> + power domains on SM6375
>>> +
>>> + See also:
>>> + - dt-bindings/clock/qcom,sm6375-gcc.h
>>> +
>>
>> Why you are not referencing qcom,gcc.yaml?
> Hm.. Out of all the SoCs we support, only apq8084 and apq/ipq8064 reference it..
> Should I add that?

Yes. There was a patchset adding references everywhere, so new code for
sure must have it.


Best regards,
Krzysztof