Re: [PATCH v2 06/11] net: phylink: Support differing link/interface speed/duplex

From: Andrew Lunn
Date: Thu Jul 21 2022 - 12:41:16 EST


> > I thought we had decided that using the term "link" in these new members
> > was a bad idea.
>
> I saw that you and Andrew were not in favor, but I did not get a response to
> my defense of this terminology. That said, this is not a terribly large
> change to make.

I know Russell tends to use media side, and i use line side. I would
be happy with either. I think we both use host side.

"link" is way to ambiguous.

I do understand you not wanting to change phydev->speed, it is used in
a lot of places. But maybe changing it is good, you then get to look
at the code and decide does it want the media speed, or the host
speed.

Andrew