Re: [PATCH v2 3/3] ARM: qcom_defconfig: order items with savedefconfig

From: Krzysztof Kozlowski
Date: Sat Jul 23 2022 - 13:31:07 EST


On 23/07/2022 11:58, Luca Weiss wrote:
> Hi Krzysztof,
>
> On Donnerstag, 21. Juli 2022 17:53:56 CEST Krzysztof Kozlowski wrote:
>> Run savedefconfig and order the entries, without removing or adding
>> anything. This reduces conflicts, as new entries should not be added to
>> the end, and makes it easier to spot differences against actual config.
>
> Could you also add a commit that regenerates it completely?
>
> rm .config; make qcom_defconfig; make savedefconfig; mv defconfig arch/arm/
> configs/qcom_defconfig
>
> There's a bunch of options not present in mainline anymore, most significant
> QCOM_ADSP_PIL and QCOM_Q6V5_PIL which are now CONFIG_QCOM_Q6V5_MSS and
> CONFIG_QCOM_Q6V5_PAS.
>
> See also
> https://lore.kernel.org/linux-arm-msm/20191104210943.101393-1-luca@xxxxxxxxx/
> (never applied for some reason)

No, I cannot, because it is wrong method and should never be used. Each
of such options needs careful investigation not to remove user-visible
symbols.


Best regards,
Krzysztof