Re: [PATCH 2/3] memory: mtk-smi: Add enable IOMMU SMC command for MM master

[Krzysztof Kozlowski]

On 23/07/2022 05:19, Chengci.Xu wrote:

Thank you for your patch. There is something to discuss/improve.

>  #endif
> diff --git a/include/soc/mediatek/smi.h b/include/soc/mediatek/smi.h
> index 11f7d6b59642..76093b856335 100644
> --- a/include/soc/mediatek/smi.h
> +++ b/include/soc/mediatek/smi.h
> @@ -8,6 +8,15 @@
>  
>  #include <linux/bitops.h>
>  #include <linux/device.h>
> +#include <linux/arm-smccc.h>
> +#include <linux/soc/mediatek/mtk_sip_svc.h>

The headers do not look like used here. Include only relevant headers.

> +
> +/* IOMMU & SMI ATF CMD */
> +
> +enum IOMMU_ATF_CMD {
> +	IOMMU_ATF_CMD_CONFIG_SMI_LARB,		/* For mm master to en/disable iommu */
> +	IOMMU_ATF_CMD_COUNT,
> +};
>  
>  #if IS_ENABLED(CONFIG_MTK_SMI)
>  


Best regards,
Krzysztof