Re: [PATCH RESEND v6 2/8] blk-throttle: prevent overflow while calculating wait time
From: Tejun Heo
Date: Wed Jul 27 2022 - 15:05:09 EST
On Fri, Jul 01, 2022 at 05:34:35PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> In tg_with_in_bps_limit(), 'bps_limit * jiffy_elapsed_rnd' might
> overflow. FIx the problem by calling mul_u64_u64_div_u64() instead.
>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
BTW, have you observed this happening or is it from just reviewing the code?
Thanks.
--
tejun