Re: [RFC PATCH v3 0/9] can: slcan: extend supported features (step 2)

[Marc Kleine-Budde]

On 26.07.2022 23:02:08, Dario Binacchi wrote:
> With this series I try to finish the task, started with the series [1],
> of completely removing the dependency of the slcan driver from the
> userspace slcand/slcan_attach applications.
> 
> The series also contains patches that remove the legacy stuff (slcan_devs,
> SLCAN_MAGIC, ...) and do some module cleanup.
> 
> The series has been created on top of the patches:
> 
> can: slcan: convert comments to network style comments
> can: slcan: slcan_init() convert printk(LEVEL ...) to pr_level()
> can: slcan: fix whitespace issues
> can: slcan: convert comparison to NULL into !val
> can: slcan: clean up if/else
> can: slcan: use scnprintf() as a hardening measure
> can: slcan: do not report txerr and rxerr during bus-off
> can: slcan: do not sleep with a spin lock held
> 
> applied to linux-next.
> 
> [1] https://lore.kernel.org/all/20220628163137.413025-1-dario.binacchi@xxxxxxxxxxxxxxxxxxxx/
> 
> Changes in v3:
> - Update the commit message.
> - Use 1 space in front of the =.
> - Put the series as RFC again.

No need to change the series to RFC again :)

> - Pick up the patch "can: slcan: use KBUILD_MODNAME and define pr_fmt to replace hardcoded names".
> - Add the patch "ethtool: add support to get/set CAN bit time register"
>   to the series.
> - Add the patch "can: slcan: add support to set bit time register (btr)"
>   to the series.
> - Replace the link https://marc.info/?l=linux-can&m=165806705927851&w=2 with
>   https://lore.kernel.org/all/507b5973-d673-4755-3b64-b41cb9a13b6f@xxxxxxxxxxxx.
> - Add the `Suggested-by' tag.

Please post a v4 with both BTR patches dropped and add Max Staudt's
Reviewed-by to patch 3.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature