Re: [PATCH v3 07/10] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery

From: Lee Jones
Date: Mon Aug 08 2022 - 12:13:35 EST


On Mon, 01 Aug 2022, Andy Shevchenko wrote:

> The driver depends on ACPI, ACPI_PTR() resolution is always the same.
> Otherwise a compiler may produce a warning.
>
> That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or
> none should be used in a driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
>
> v3: no changes
> v2: added tags and rebased on top of new patch 1
>
> drivers/mfd/Kconfig | 4 ++--
> drivers/mfd/intel_soc_pmic_crc.c | 6 ++----
> 2 files changed, 4 insertions(+), 6 deletions(-)

Applied, thanks.

--
DEPRECATED: Please use lee@xxxxxxxxxx