Re: [PATCH v2 1/2] asus-wmi: Adjust tablet/lidflip handling to use enum
From: Hans de Goede
Date: Mon Aug 08 2022 - 12:13:39 EST
Hi,
On 8/8/22 17:48, Andy Shevchenko wrote:
> On Mon, Aug 8, 2022 at 5:12 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:
>>
>> Due to multiple types of tablet/lidflip, the existing code for
>> handlign these events is refactored to use an enum for each type.
>
> handling
>
> Can you run a spell checker for your commit messages?
>
> ...
>
> To the switch-cases, please add a "default" case to each of them.
The switch-cases are on an enum type, so adding a default is
not necessary and adding one will actually loose the useful
compiler warning about unhandled enum values.
Regards,
Hans