Re: [PATCH] ASoC: Intel: kbl_rt5663_max98927: Simplify clk_get() usage

[Christophe JAILLET]

Le 10/08/2022 à 15:50, Mark Brown a écrit :
> On Sun, Aug 07, 2022 at 10:18:54PM +0200, Christophe JAILLET wrote:
> > If clk_get() returns -ENOENT, there is no need to defer the driver, -ENOENT
> > will be returned the same for each retries.
> > So, return the error code directly instead of -EPROBE_DEFER.
>
> Are you *sure* that this is the case on Intel platforms where we don't
> have a full firmware description for clocks and therefore can't identify
> cases where we expect a clock to at some point to become available.

No, I'm *not* sure.

This looked odd enough to deserve a patch proposal, that's all.
(based on my grep and coccinelle scripts, this is the only place in the 
kernel where the result of a clk_get() is handled that way)

There are many intel.com in cc:.
Would be nice if s.o. could confirm if the patch is valid or not.

CJ