Re: [PATCH 03/13] ASoC: amd: add acp6.2 init/de-init functions

[Mark Brown]

On Fri, Aug 12, 2022 at 05:37:21PM +0530, Syed Saba kareem wrote:

> +	/* power on */
> +	ret = acp62_power_on(acp_base);
> +	if (ret) {
> +		pr_err("ACP power on failed\n");
> +		return ret;
> +	}

It would be better if you passed the device in so messages like this
could be dev_err() rather than just pr_err().

Attachment: signature.asc
Description: PGP signature