Re: [PATCH] perf: python: Fix build when PYTHON_CONFIG is user supplied

[Arnaldo Carvalho de Melo]

Em Mon, Aug 22, 2022 at 11:08:37AM +0100, James Clark escreveu:
> 
> 
> On 28/07/2022 20:26, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 28, 2022 at 09:37:32AM -0700, Ian Rogers escreveu:
> >> On Thu, Jul 28, 2022 at 2:40 AM James Clark <james.clark@xxxxxxx> wrote:
> >>>
> >>> The previous change to Python autodetection had a small mistake where
> >>> the auto value was used to determine the Python binary, rather than the
> >>> user supplied value. The Python binary is only used for one part of the
> >>> build process, rather than the final linking, so it was producing
> >>> correct builds in most scenarios, especially when the auto detected
> >>> value matched what the user wanted, or the system only had a valid set
> >>> of Pythons.
> >>>
> >>> Change it so that the Python binary path is derived from either the
> >>> PYTHON_CONFIG value or PYTHON value, depending on what is specified by
> >>> the user. This was the original intention.
> >>>
> >>> This error was spotted in a build failure an odd cross compilation
> >>> environment after commit 4c41cb46a732fe82 ("perf python: Prefer
> >>> python3") was merged.
> >>>
> >>> Fixes: 630af16eee495f58 ("perf tools: Use Python devtools for version autodetection rather than runtime")
> >>> Signed-off-by: James Clark <james.clark@xxxxxxx>
> >>
> >> Acked-by: Ian Rogers <irogers@xxxxxxxxxx>
> > 
> > Thanks, applied.
> 
> Hi Arnaldo,
> 
> I couldn't find this change in any of your branches. Do you know if it
> got dropped somehow or was there an issue with it?

Applied it to my local perf/urgent branch, testing now. I thought I had
processed it, not really :-\

- Arnaldo