Re: [PATCH] Do not name control queue for virtio-net
From: Michael S. Tsirkin
Date: Thu Sep 22 2022 - 05:17:25 EST
On Thu, Sep 22, 2022 at 11:10:37AM +0200, Paolo Abeni wrote:
> On Sun, 2022-09-18 at 08:17 -0400, Michael S. Tsirkin wrote:
> > On Sun, Sep 18, 2022 at 05:00:20PM +0800, Junbo wrote:
> > > hi Michael
> > >
> > > in virtio-net.c
> > > /* Parameters for control virtqueue, if any */
> > > if (vi->has_cvq) {
> > > callbacks[total_vqs - 1] = NULL;
> > > names[total_vqs - 1] = "control";
> > > }
> > >
> > > I think the Author who write the code
> >
> > wait, that was not you?
>
> I believe 'the Author' refers to the author of the current code, not to
> the author of the patch.
Oh I see. Responded.
> @Junbo: the control queue is created only if the VIRTIO_NET_F_CTRL_VQ
> feature is set, please check that in your setup.
>
> Thanks
>
> Paolo
--
MST