Re: [PATCH RESEND v1 1/9] crypto/ycc: Add YCC (Yitian Cryptography Complex) accelerator driver
From: guanjun
Date: Thu Sep 22 2022 - 21:54:03 EST
> 2022年9月16日 下午5:35,Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> 写道:
>
> On Tue, Sep 06, 2022 at 11:35:45AM +0800, 'Guanjun' wrote:
> .
>> +static const struct file_operations ycc_fops = {
>> + .open = ycc_cdev_open,
>> + .release = ycc_cdev_release,
>> + .unlocked_ioctl = ycc_cdev_ioctl,
>> +};
>
> What is this device for? It doesn't seem to do anything so why
> not jsut drop it?
>
> Thanks,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Herbert,
Do you have any other comments? If not, I will prepare for the next version :)
Thanks,
Regards,
Guanjun