Re: [PATCH 6/7] scsi: pm8001: use dev_and_phy_addr_same() instead of open coded

[Jason Yan]

On 2022/9/22 22:24, John Garry wrote:
> On 17/09/2022 11:43, Jason Yan wrote:
> > The sas address comparation of domain device and expander phy is open
> > coded. Now we can replace it with dev_and_phy_addr_same().
> >
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > ---
> >   drivers/scsi/pm8001/pm8001_sas.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/pm8001/pm8001_sas.c 
> > b/drivers/scsi/pm8001/pm8001_sas.c
> > index 8e3f2f9ddaac..bb1b1722f3ee 100644
> > --- a/drivers/scsi/pm8001/pm8001_sas.c
> > +++ b/drivers/scsi/pm8001/pm8001_sas.c
> > @@ -649,8 +649,7 @@ static int pm8001_dev_found_notify(struct 
> > domain_device *dev)
> >           for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys;
>
> This code seems the same between many libsas LLDDs - could we factor it 
> out into libsas?

Sure we can. I will try to factor it out in the next revision.

Thanks,
Jason

 If so, then maybe those new helpers could be put in
> sas_internal.h
>
> Thanks,
> John
>
> >           phy_id++) {
> >               phy = &parent_dev->ex_dev.ex_phy[phy_id];
> > -            if (SAS_ADDR(phy->attached_sas_addr)
> > -                == SAS_ADDR(dev->sas_addr)) {
> > +            if (dev_and_phy_addr_same(dev, phy)) {
> >                   pm8001_device->attached_phy = phy_id;
> >                   break;
> >               }
>
> .