Re: [RFC PATCH] dt-bindings: net: ethernet-controller: Add ptimer_handle
From: Richard Cochran
Date: Mon Oct 03 2022 - 10:20:59 EST
On Mon, Oct 03, 2022 at 09:29:00AM +0000, Gaddam, Sarath Babu Naidu wrote:
> PHC(PTP Hardware clock) index is a number which is used by ptp4l
> application. When a PTP device registers with a kernel, device node
> will be created in the /dev.For example, /dev/ptp0, /dev/ptp1.
>
> When PTP and Ethernet are in the same device driver, This PHC index
> Information is internally accessible. When they are independent drivers,
> PTP DT node should be linked to ethernet node so that PTP timer
> information such as PHC index is accessible.
Good explanation. The handle you propose makes sense to me.
Maybe let the name spell it out clearly?
fman0: fman@1a00000 {
ptp-hardware-clock = <&phc0>;
}
phc0: ptp-timer@1afe000 {
compatible = "fsl,fman-ptp-timer";
reg = <0x0 0x1afe000 0x0 0x1000>;
}
In any case, to me "timer" has a different connotation than "clock".
Thanks,
Richard