Re: [PATCH] mtd: spi-nor: winbond: add support for w25q01jv-im

[Patrick Williams]

On Thu, Oct 06, 2022 at 01:52:33PM +0200, Michael Walle wrote:
> Hi,
> 
> Am 2022-10-06 09:08, schrieb Delphine CC Chiu:
> > Add support for winbond w25q01jv-im chip.
> > 
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> >  drivers/mtd/spi-nor/winbond.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/winbond.c 
> > b/drivers/mtd/spi-nor/winbond.c
> > index ffaa24055259..2b02b05ceb0a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -139,6 +139,9 @@ static const struct flash_info winbond_nor_parts[] 
> > = {
> >  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> >  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> >  			      SPI_NOR_QUAD_READ) },
> > +	{ "w25q01jv-im", INFO(0xef7021, 0, 64 * 1024, 2048)
> 
> The name should be w25q01jvm.
> 
> > +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> > +			      SPI_NOR_QUAD_READ) },
> 
> That flash should support SFDP, so please try the following:
> +	{ "w25q01jvm", INFO(0xef7021, 0, 0, 0) PARSE_SFDP },
> 
> Also, we require an SFDP dump for new flash submissions, see [1].
> 
> -michael
> 
> [1] 
> https://lore.kernel.org/linux-mtd/4304e19f3399a0a6e856119d01ccabe0@xxxxxxxx/

It looks like this was already attempted to be added:

https://lore.kernel.org/all/20220222085148.21594-1-potin.lai@xxxxxxxxxxxx/

Potin, do you have an update?

-- 
Patrick Williams

Attachment: signature.asc
Description: PGP signature