RE: [PATCH] Change the I2C slave address for ds4422/4424 to its correct value

[Khandelwal, Rajat]

Hi,
I don't know how I missed subject prefixes, sorry for that.
Upstreaming patches for dt is something new for me so was
skeptical on dt validation. However, I have run it now and it
passes for me.

Have sent a v2 for you to review.

Thanks

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> 
Sent: Tuesday, October 11, 2022 12:08 AM
To: Rajat Khandelwal <rajat.khandelwal@xxxxxxxxxxxxxxx>; jic23@xxxxxxxxxx; lars@xxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; ihkose@xxxxxxxxx
Cc: linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Khandelwal, Rajat <rajat.khandelwal@xxxxxxxxx>
Subject: Re: [PATCH] Change the I2C slave address for ds4422/4424 to its correct value

On 11/10/2022 14:24, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20 
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.

Use subject prefixes matching the subsystem (git log --oneline -- ...).


> 
> Let me know if I am wrong about this.

This does not belong to the commit msg.

> 
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@xxxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml 
> b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> index 264fa7c5fe3a..1955b1a97cd6 100644
> --- a/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml
> @@ -38,7 +38,7 @@ examples:
>  
>          dac@10 {
>              compatible = "maxim,ds4424";
> -            reg = <0x10>; /* When A0, A1 pins are ground */
> +            reg = <0x20>; /* When A0, A1 pins are ground */

Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions).

>              vcc-supply = <&vcc_3v3>;
>          };
>      };

Best regards,
Krzysztof