RE: [PATCH] arm64: dts: fix drive strength macros as per FSD HW UM

[Padmanabhan Rajanbabu]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
> Sent: 10 October 2022 06:54 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx>;
> robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> alim.akhtar@xxxxxxxxxxx; chanho61.park@xxxxxxxxxxx;
> linus.walleij@xxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] arm64: dts: fix drive strength macros as per FSD HW UM
> 
> On 10/10/2022 08:04, Padmanabhan Rajanbabu wrote:
> > In FSD pinctrl implementation, the pinctrl driver is using drive
> > strength MACROs, which are deviating from the actual values specified
> > in FSD HW UM
> 
> But you are changing DTS, not pinctrl driver. The message is a bit confusing.
Sorry about the commit description. I'll update it to reflect the right context.
> 
> Add full stop to the sentence.
okay
> 
> >
> > This patch adds the right pinctrl drive strength values for FSD SoC.
> > This
> 
> Do not use "This commit/patch".
> https://protect2.fireeye.com/v1/url?k=7c0c10dd-239729b8-7c0d9b92-
> 000babff32e3-25043687ce355c88&q=1&e=110f55cc-c214-4bfd-b74b-
> 928d7f2efcbc&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.17.1%2F
> source%2FDocumentation%2Fprocess%2Fsubmitting-patches.rst%23L95
Okay.
> 
> > patch also ensures that the peripherals are using right drive strength
> > MACROs in-order to function as expected
> 
> Full stop
Okay.
> 
> Which commit introduced it? Add a Fixes tag.
I'll add the fixes tag.
> 
> 
> >
> > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 34 +++++++++++-----------
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.h    |  6 ++--
> >  2 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > index d0abb9aa0e9e..e3852c946352 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > @@ -55,14 +55,14 @@
> >  		samsung,pins = "gpf5-0";
> >  		samsung,pin-function = <FSD_PIN_FUNC_2>;
> >  		samsung,pin-pud = <FSD_PIN_PULL_NONE>;
> > -		samsung,pin-drv = <FSD_PIN_DRV_LV2>;
> > +		samsung,pin-drv = <FSD_PIN_DRV_LV4>;
> 
> Are you sure? The original commit used here value of "2", your change also
> set value of "2", so what deviates from actual values?
The intention of the patch is to change the value of MACROs as well as name of the MACROs
according to the FSD HW user manual.
> 
> You need to describe better the problem.
In the next version, I'll update the problem description in a much better way.
> 
> Best regards,
> Krzysztof
Thanks for quick review.

Regards,
Padmanabhan R.