Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller
From: Krzysztof Kozlowski
Date: Wed Oct 19 2022 - 10:16:40 EST
On 19/10/2022 09:48, Köry Maincent wrote:
> Hello Krzysztof,
>
> On Wed, 19 Oct 2022 09:38:45 -0400
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
>> On 19/10/2022 09:32, Köry Maincent wrote:
>>> From: Kory Maincent <kory.maincent@xxxxxxxxxxx>
>>>
>>> Enable the PL110 DRM driver, used by the spear600.
>>>
>>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
>>
>> I2C as a user-selectable option should stay. Don't remove such
>> (user-selectable) top-level options just because something else selected it.
>
> As the CONFIG_DRM selects it, the "make savedefconfig" removes it by default.
> Why keeping something that is already automatically enabled by CONFIG_DRM?
Same question every few months :)
Because otherwise we can drop select in DRM and do not update the
defconfigs.
https://patchwork.kernel.org/project/linux-samsung-soc/patch/20191125125515.30795-1-m.szyprowski@xxxxxxxxxxx/#23021125
https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/
https://lore.kernel.org/all/c5150e83-0e50-3be6-b6bd-bf30fe5e94d1@xxxxxxxxxx/
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a2315d3aea5976acd919d3d3fcf82f752562c25b
Best regards,
Krzysztof