Re: [PATCH 3/6] arm: configs: spear6xx: Enable PL110 display controller
From: Köry Maincent
Date: Wed Oct 19 2022 - 10:34:30 EST
Krzysztof
On Wed, 19 Oct 2022 09:57:26 -0400
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 19/10/2022 09:48, Köry Maincent wrote:
> > Hello Krzysztof,
> >
> > On Wed, 19 Oct 2022 09:38:45 -0400
> > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >
> >> On 19/10/2022 09:32, Köry Maincent wrote:
> >>> From: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> >>>
> >>> Enable the PL110 DRM driver, used by the spear600.
> >>>
> >>> CONFIG_I2C is dropped from the defconfig as it is selected by CONFIG_DRM.
> >>>
> >>
> >> I2C as a user-selectable option should stay. Don't remove such
> >> (user-selectable) top-level options just because something else selected
> >> it.
> >
> > As the CONFIG_DRM selects it, the "make savedefconfig" removes it by
> > default. Why keeping something that is already automatically enabled by
> > CONFIG_DRM?
>
> Same question every few months :)
>
> Because otherwise we can drop select in DRM and do not update the
> defconfigs.
Alright, thanks, I will update it in V2.
I will be more careful with savedefconfig for now !
Köry