Re: [PATCH v3 3/7] mmc: sdhci-brcmstb: Fix SDHCI_RESET_ALL for CQHCI

[Florian Fainelli]

On 10/24/22 10:54, Brian Norris wrote:
>   [[ NOTE: this is completely untested by the author, but included solely
>      because, as noted in commit df57d73276b8 ("mmc: sdhci-pci: Fix
>      SDHCI_RESET_ALL for CQHCI for Intel GLK-based controllers"), "other
>      drivers using CQHCI might benefit from a similar change, if they
>      also have CQHCI reset by SDHCI_RESET_ALL." We've now seen the same
>      bug on at least MSM, Arasan, and Intel hardware. ]]
>
> SDHCI_RESET_ALL resets will reset the hardware CQE state, but we aren't
> tracking that properly in software. When out of sync, we may trigger
> various timeouts.
>
> It's not typical to perform resets while CQE is enabled, but this may
> occur in some suspend or error recovery scenarios.
>
> Include this fix by way of the new sdhci_and_cqhci_reset() helper.
>
> Fixes: d46ba2d17f90 ("mmc: sdhci-brcmstb: Add support for Command Queuing (CQE)")
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian