Re: BUG: bisected: thermald regression (MEMLEAK) in commit c7ff29763989bd09c433f73fae3c1e1c15d9cda4

From: Mirsad Goran Todorovac
Date: Mon Oct 24 2022 - 16:51:46 EST


On 24. 10. 2022. 20:39, srinivas pandruvada wrote:

Thank you for the patch. Unfortunately, when applied to v6.0.3 it
didn't
fix the issue.
Thanks for the test. I copied to acpi and acpica mailing list. Someone
can tell us what is this call doing wrong here.
Seems like a prudent thing to do. It must be heavy to provide support for all of the
hardware on the market ...

Maybe this will help (however, this dmesg -l err was the same in "git bisect good" and "git bisect bad" kernels!):

root@marvin-IdeaPad-3-15ITL6:~# dmesg -l err
[    0.121673] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PCI0], AE_NOT_FOUND (20220331/dswload2-163)
[    0.121688] ACPI Error: AE_NOT_FOUND, During name lookup/catalog (20220331/psobject-221)
[    0.142742] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PC00.DGPV], AE_NOT_FOUND (20220331/psargs-330)
[    0.142751] ACPI Error: Aborting method \_SB.PC00.PEG0.PCRP._ON due to previous error (AE_NOT_FOUND) (20220331/psparse-531)
[    0.308625] integrity: Problem loading X.509 certificate -65
[    2.731846] mtd device must be supplied (device name is empty)
[    3.226997] i801_smbus 0000:00:1f.4: Transaction timeout
[    3.229085] i801_smbus 0000:00:1f.4: Failed terminating the transaction
[    3.229194] i801_smbus 0000:00:1f.4: SMBus is busy, can't use it!
[    3.515909] mtd device must be supplied (device name is empty)
[    4.600624] ACPI BIOS Error (bug): Could not resolve symbol [\_TZ.ETMD], AE_NOT_FOUND (20220331/psargs-330)
[    4.600741] ACPI Error: Aborting method \_SB.IETM._OSC due to previous error (AE_NOT_FOUND) (20220331/psparse-531)
[    5.110999] Bluetooth: hci0: Malformed MSFT vendor event: 0x02
[    5.173006] Bluetooth: hci0: HCI_REQ-0xfc1e
root@marvin-IdeaPad-3-15ITL6:~# dmesg | grep _OSC
[    0.131652] ACPI: \_SB_.PR00: _OSC native thermal LVT Acked
[    0.167416] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI EDR HPX-Type3]
[    0.169119] acpi PNP0A08:00: _OSC: platform does not support [AER]
[    0.172500] acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug SHPCHotplug PME PCIeCapability LTR DPC]
[    4.600655] No Local Variables are initialized for Method [_OSC]
[    4.600660] Initialized Arguments for Method [_OSC]:  (4 arguments defined for method invocation)
[    4.600741] ACPI Error: Aborting method \_SB.IETM._OSC due to previous error (AE_NOT_FOUND) (20220331/psparse-531)
root@marvin-IdeaPad-3-15ITL6:~#

marvin@marvin-IdeaPad-3-15ITL6:~$ uname -rms
Linux 6.0.3-18-fix01-mlk+ x86_64
marvin@marvin-IdeaPad-3-15ITL6:~$ sudo bash
[sudo] password for marvin:
root@marvin-IdeaPad-3-15ITL6:/home/marvin# cat
/sys/kernel/debug/kmemleak
root@marvin-IdeaPad-3-15ITL6:/home/marvin# echo scan >
/sys/kernel/debug/kmemleak
root@marvin-IdeaPad-3-15ITL6:/home/marvin# cat
/sys/kernel/debug/kmemleak
unreferenced object 0xffff998b030c3370 (size 80):
   comm "thermald", pid 824, jiffies 4294893654 (age 67.080s)
   hex dump (first 32 bytes):
     00 00 00 00 00 00 00 00 0d 01 2d 00 00 00 00 00 ..........-.....
     af 07 01 c0 6f bc ff ff 00 00 00 00 00 00 00 00 ....o...........
   backtrace:
     [<00000000490225c2>] slab_post_alloc_hook+0x80/0x2e0
     [<00000000dc142b33>] kmem_cache_alloc+0x166/0x2e0
     [<00000000168f1071>] acpi_os_acquire_object+0x2c/0x32
     [<00000000fcc615e1>] acpi_ps_alloc_op+0x4a/0x99
     [<00000000fb475bb4>] acpi_ps_get_next_arg+0x611/0x761
     [<000000009048d529>] acpi_ps_parse_loop+0x494/0x8d7
     [<000000005b0bf086>] acpi_ps_parse_aml+0x1bb/0x561
     [<000000007ab7e288>] acpi_ps_execute_method+0x20f/0x2d5
     [<00000000c12fa6b7>] acpi_ns_evaluate+0x34d/0x4f3
     [<000000001be94719>] acpi_evaluate_object+0x180/0x3ae
     [<00000000423a7ad5>] acpi_run_osc+0x128/0x250
     [<0000000040a72af8>] int3400_thermal_run_osc+0x6f/0xc0
[int3400_thermal]
     [<00000000f8d59987>] current_uuid_store+0xe3/0x120
[int3400_thermal]
     [<000000007e2e2d17>] dev_attr_store+0x14/0x30
     [<00000000b824b589>] sysfs_kf_write+0x38/0x50
     [<00000000beae69c1>] kernfs_fop_write_iter+0x146/0x1d0
root@marvin-IdeaPad-3-15ITL6:/home/marvin#

The build process was as follows:

  1573  10/24/2022 06:41:53 PM  cd linux_stable
  1574  10/24/2022 06:42:03 PM  git checkout v6.0.3
  1575  10/24/2022 06:42:44 PM  cd ..
  1576  10/24/2022 06:42:50 PM  time rm -rf linux_stable_build; time
cp
-rp linux_stable linux_stable_build; \
                     time diff -ur linux_stable linux_stable_build;
cd
linux_stable_build
  1577  10/24/2022 06:46:19 PM  git apply ../thermald-20221024-
01.diff
  1578  10/24/2022 06:46:28 PM  vi ../config-5.15.0-50-memleak
  1579  10/24/2022 06:47:08 PM  cp ../config-5.15.0-50-memleak
.config
  1580  10/24/2022 06:47:16 PM  make olddefconfig
  1581  10/24/2022 06:48:42 PM  time nice make CC="ccache gcc"
KBUILD_BUILD_TIMESTAMP="" -j10 deb-pkg; date

I think your patch definitively makes sense, but there's more to this
than meets the eye :-/

Hope this helps.

Thanks
Mirsad

--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu

--
Mirsad Goran Todorovac
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu
--
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb, Republic of Croatia
The European Union