Re: [PATCH 1/3] media: uvc_driver: fix missing newline after declarations

[Pedro Guilherme Siqueira Moreira]

Hi Laurent,

Thanks for the heads up!  I'm fixing it right now.

On 10/24/22 22:36, Laurent Pinchart wrote:
> Hi Pedro,
>
> Thank you for the patch.
>
> On Mon, Oct 24, 2022 at 10:03:01PM -0300, Pedro Guilherme Siqueira Moreira wrote:
>
> The code change looks good, but the commit message is missing. Same for
> the other two patches in the series.
>
> > Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/media/usb/uvc/uvc_driver.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 215fb483efb0..b591ad823c66 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev,
> >   	/* Parse the alternate settings to find the maximum bandwidth. */
> >   	for (i = 0; i < intf->num_altsetting; ++i) {
> >   		struct usb_host_endpoint *ep;
> > +
> >   		alts = &intf->altsetting[i];
> >   		ep = uvc_find_endpoint(alts,
> >   				streaming->header.bEndpointAddress);
> > @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref)
> >   
> >   	list_for_each_safe(p, n, &dev->chains) {
> >   		struct uvc_video_chain *chain;
> > +
> >   		chain = list_entry(p, struct uvc_video_chain, list);
> >   		kfree(chain);
> >   	}
> >   
> >   	list_for_each_safe(p, n, &dev->entities) {
> >   		struct uvc_entity *entity;
> > +
> >   		entity = list_entry(p, struct uvc_entity, list);
> >   #ifdef CONFIG_MEDIA_CONTROLLER
> >   		uvc_mc_cleanup_entity(entity);
> > @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref)
> >   
> >   	list_for_each_safe(p, n, &dev->streams) {
> >   		struct uvc_streaming *streaming;
> > +
> >   		streaming = list_entry(p, struct uvc_streaming, list);
> >   		usb_driver_release_interface(&uvc_driver.driver,
> >   			streaming->intf);