[PATCH] x86/retpoline: Fix crash printing warning
From: Dan Carpenter
Date: Tue Oct 25 2022 - 11:33:45 EST
The first argument of WARN() is a condition, so this will use "addr"
as the format string and possibly crash.
Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 19221d77dc27..b4ac4e58c010 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -418,7 +418,7 @@ static int emit_call_track_retpoline(void *addr, struct insn *insn, int reg, u8
break;
default:
- WARN("%pS %px %*ph\n", addr, addr, 6, addr);
+ WARN(1, "%pS %px %*ph\n", addr, addr, 6, addr);
return -1;
}
--
2.35.1