Re: [PATCH] x86/retpoline: Fix crash printing warning

[Ammar Faizi]

On 10/25/22 10:32 PM, Dan Carpenter wrote:
> The first argument of WARN() is a condition, so this will use "addr"
> as the format string and possibly crash.
>
> Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Hello x86 maintainers,

I found this patch in the tip tree with the following commit message:

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/core&id=98dcf58159365d753b54d07f85a89d61ee15e036

	x86/retpoline: Fix crash printing warningx86/core

	The first argument of WARN() is a condition, so this will use "addr"
	as the format string and possibly crash.

	Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
	Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
	Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
	Link: https://lkml.kernel.org/r/Y1gBoUZrRK5N/lCB@kili

When I visited that lkml link, it shows "message ID not found". The
problem seems to be coming from the tool used to pick up the patch.

That message ID contains a URL special char '/'. Thus it should be
URL-encoded like this:

   https://lore.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili

Anyway, lkml.kernel.org doesn't work for such a message ID, even with
URL-encoded message ID like this:

   https://lkml.kernel.org/r/Y1gBoUZrRK5N%2FlCB%40kili (not found)

--
Ammar Faizi