Re: [PATCH 9/9] fscache,netfs: move "fscache_" prefixed structures to fscache.h

From: David Howells
Date: Thu Oct 27 2022 - 09:14:33 EST


Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:

> diff --git a/include/linux/netfs.h b/include/linux/netfs.h
> index 2ad4e1e88106..1977f953633a 100644
> --- a/include/linux/netfs.h
> +++ b/include/linux/netfs.h
> @@ -16,19 +16,10 @@
>
> #include <linux/workqueue.h>
> #include <linux/fs.h>
> +#include <linux/fscache.h>

Please don't do that. fscache is based on netfslib, not the other way around.

If anything, I'm tempted to move fscache into netfslib.

David