Re: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon

From: Sam Protsenko
Date: Fri Nov 25 2022 - 09:15:26 EST


On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
>
> Cc: Sriranjani P <sriranjani.p@xxxxxxxxxxx>
> Cc: Chanho Park <chanho61.park@xxxxxxxxxxx>
> Cc: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>

> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 1b01bd010431..b73ba1ea08f7 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
> - - samsung,exynos3-sysreg
> - - samsung,exynos4-sysreg
> - - samsung,exynos5-sysreg
> - - samsung,exynos5433-sysreg
> - - samsung,exynos850-sysreg
> - - samsung,exynosautov9-sysreg
>
> - const: syscon
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> new file mode 100644
> index 000000000000..68064a5e339c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC series System Registers (SYSREG)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - samsung,exynos3-sysreg
> + - samsung,exynos4-sysreg
> + - samsung,exynos5-sysreg
> + - samsung,exynos5433-sysreg
> + - samsung,exynos850-sysreg
> + - samsung,exynosautov9-sysreg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + system-controller@10010000 {
> + compatible = "samsung,exynos4-sysreg", "syscon";
> + reg = <0x10010000 0x400>;
> + };
> --
> 2.34.1
>