RE: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon

From: Alim Akhtar
Date: Fri Nov 25 2022 - 11:57:27 EST




>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Friday, November 25, 2022 4:52 PM
>To: Lee Jones <lee@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Sriranjani P
><sriranjani.p@xxxxxxxxxxx>; Chanho Park <chanho61.park@xxxxxxxxxxx>;
>Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>Subject: [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from
>syscon
>
>Split Samsung Exynos SoC SYSREG bindings to own file to narrow the bindings
>and do not allow other parts of syscon.yaml. This allows further
customization
>of Samsung SoC bindings.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>---
>
>Cc: Sriranjani P <sriranjani.p@xxxxxxxxxxx>
>Cc: Chanho Park <chanho61.park@xxxxxxxxxxx>
>Cc: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39
>+++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-) create mode 100644
>Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>
>diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>b/Documentation/devicetree/bindings/mfd/syscon.yaml
>index 1b01bd010431..b73ba1ea08f7 100644
>--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>@@ -64,12 +64,6 @@ properties:
> - rockchip,rk3568-qos
> - rockchip,rk3588-qos
> - rockchip,rv1126-qos
>- - samsung,exynos3-sysreg
>- - samsung,exynos4-sysreg
>- - samsung,exynos5-sysreg
>- - samsung,exynos5433-sysreg
>- - samsung,exynos850-sysreg
>- - samsung,exynosautov9-sysreg
>
> - const: syscon
>
>diff --git
>a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysreg.yaml
>new file mode 100644
>index 000000000000..68064a5e339c
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-
>sysre
>+++ g.yaml
>@@ -0,0 +1,39 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
>+---
>+$id:
>+https://protect2.fireeye.com/v1/url?k=66a4ea1d-393fd378-66a56152-
>000bab
>+ff32e3-46dd8d7834263379&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fschemas%2Fsoc%2Fsamsung%2Fsamsung
>%2Cexynos-
>+sysreg.yaml%23
>+$schema:
>+https://protect2.fireeye.com/v1/url?k=0bf71500-546c2c65-0bf69e4f-000bab
>+ff32e3-2ad7163b19d3c132&q=1&e=0e7cbbb5-e02f-4452-b6ad-
>5f17f37da091&u=ht
>+tp%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23
>+
>+title: Samsung Exynos SoC series System Registers (SYSREG)
>+
>+maintainers:
>+ - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>+
>+properties:
>+ compatible:
>+ oneOf:
>+ - items:
>+ - enum:
>+ - samsung,exynos3-sysreg
>+ - samsung,exynos4-sysreg
>+ - samsung,exynos5-sysreg
>+ - samsung,exynos5433-sysreg
>+ - samsung,exynos850-sysreg
>+ - samsung,exynosautov9-sysreg
>+ - const: syscon
>+
>+ reg:
>+ maxItems: 1
>+
>+required:
>+ - compatible
>+ - reg
>+
>+additionalProperties: false
>+
>+examples:
>+ - |
>+ system-controller@10010000 {
>+ compatible = "samsung,exynos4-sysreg", "syscon";
>+ reg = <0x10010000 0x400>;
>+ };
>--
>2.34.1