Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct IRQ" mode

[Andy Shevchenko]

On Fri, Nov 25, 2022 at 08:11:14AM +0200, Mika Westerberg wrote:
> On Fri, Nov 25, 2022 at 12:29:26AM +0200, Andy Shevchenko wrote:
> > The firmware on some systems may configure GPIO pins to be
> > an interrupt source in so called "direct IRQ" mode. In such
> > cases the GPIO controller driver has no idea if those pins
> > are being used or not. At the same time, there is a known bug
> > in the firmwares that don't restore the pin settings correctly
> > after suspend, i.e. by an unknown reason the Rx value becomes
> > inverted.
> > 
> > Hence, let's save and restore the pins that are configured
> > as GPIOs in the input mode with GPIROUTIOXAPIC bit set.
> > 
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reported-and-tested-by: Dale Smith <dalepsmith@xxxxxxxxx>
> > Reported-and-tested-by: John Harris <jmharris@xxxxxxxxx>
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214749
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Thanks Andy!
> 
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thank you!

Linus, this would be nice to have in v6.1 release, if possible.

-- 
With Best Regards,
Andy Shevchenko