Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct IRQ" mode
From: Linus Walleij
Date: Mon Nov 28 2022 - 15:42:48 EST
On Thu, Nov 24, 2022 at 11:29 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> The firmware on some systems may configure GPIO pins to be
> an interrupt source in so called "direct IRQ" mode. In such
> cases the GPIO controller driver has no idea if those pins
> are being used or not. At the same time, there is a known bug
> in the firmwares that don't restore the pin settings correctly
> after suspend, i.e. by an unknown reason the Rx value becomes
> inverted.
>
> Hence, let's save and restore the pins that are configured
> as GPIOs in the input mode with GPIROUTIOXAPIC bit set.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-and-tested-by: Dale Smith <dalepsmith@xxxxxxxxx>
> Reported-and-tested-by: John Harris <jmharris@xxxxxxxxx>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214749
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>
> Linus, I hope that this can still make v6.1 release. I'm not going to
> send a PR for this change unless you insist.
Patch applied for fixes, plan is to get it to Torvalds
ASAP!
Yours,
Linus Walleij