Re: [PATCH 1/8] dt-bindings: soc: socionext: Add UniPhier system controller

From: Kunihiko Hayashi
Date: Thu Dec 01 2022 - 03:29:50 EST


On 2022/12/01 0:24, Krzysztof Kozlowski wrote:
On 30/11/2022 09:59, Kunihiko Hayashi wrote:
+maintainers:
+ - Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
+
+description: |+
+ System controller implemented on Socionext UniPhier SoCs has multiple
+ functions such as clock control, reset control, internal watchdog
timer,
+ thermal management, and so on.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - socionext,uniphier-ld4-sysctrl
+ - socionext,uniphier-pro4-sysctrl
+ - socionext,uniphier-pro5-sysctrl
+ - socionext,uniphier-pxs2-sysctrl
+ - socionext,uniphier-ld6b-sysctrl
+ - socionext,uniphier-sld8-sysctrl
+ - socionext,uniphier-ld11-sysctrl
+ - socionext,uniphier-ld20-sysctrl
+ - socionext,uniphier-pxs3-sysctrl
+ - socionext,uniphier-nx1-sysctrl

All of them can have children or only some?

In case of this system controller,
all SoCs has clock-controller, reset-controller and watchdog.

However, some SoCs don't have thermal-sensor and
their register addresses are reserved.

OK


+ - socionext,uniphier-sysctrl

What about this one? What SoC is this? Looks too generic.

It's the same one as soc-glue, so it should be placed as follows.

items:
- enum:
- ...
- ...
- const: socionext,uniphier-sysctrl

However, currently it is no use for now. I'll drop it.

Thank you,

---
Best Regards
Kunihiko Hayashi