Re: [PATCH 7/8] dt-bindings: soc: socionext: Add UniPhier DWC3 USB glue layer

[Kunihiko Hayashi]

On 2022/12/01 0:32, Krzysztof Kozlowski wrote:
> On 30/11/2022 10:00, Kunihiko Hayashi wrote:
> > Hi Krzysztof,
> >
> > On 2022/11/29 23:52, Krzysztof Kozlowski wrote:
> > > On 29/11/2022 11:35, Kunihiko Hayashi wrote:
> > > > Add DT binding schema for components belonging to the platform-specific
> > > > DWC3 USB glue layer implemented in UniPhier SoCs.
> > > >
> > > > This USB glue layer works as a sideband logic for the host controller,
> > > > including core reset, vbus control, PHYs, and some signals to the
> > > > controller.
> > > >
> > > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>

(snip)

> > > > +examples:
> > > > +  - |
> > > > +    usb-controller@65b00000 {
> > >
> > > Node name: usb. There is no usage of "usb-controller".
> >
> > I'm confusing about that.
> >
> > This is an interface logic and doesn't have USB functions by itself.
> > Surely there is a USB host controller node "usb@..." in the same SoC.
> > Can this node be renamed to "usb"?
> >
> > I've renamed the dts node name once in commit 4cc752a88ca9
> > ("arm64: dts: uniphier: Rename usb-glue node for USB3 to usb-controller").
>
> In (almost?) all other cases it is still called "usb". A bit akward to
> have usb in usb, but usb-controller did not stick...

I see.
I understand that it is still better to use the generic name "usb"
rather than "usb-controller".

Thank you,

---
Best Regards
Kunihiko Hayashi