Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller

[Icenowy Zheng]

在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
> On 02/12/2022 09:16, Icenowy Zheng wrote:
> > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
> > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator
> > (can
> > be bypassed) and an external reset pin.
> > 
> > Add a device tree binding for its USB protocol part. The internal
> > LDO is
> > not covered by this and can just be modelled as a fixed regulator.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@xxxxxxxxxx>
> > ---
> > Changes in v2:
> > - Misc fixes suggested by Krzysztof, including property
> > descriptions,
> >   single-item "items" and fixing the example's gpio property.
> > - Fixed $id.
> > 
> (...)
> 
> > +
> > +examples:
> > +  - |
> > +    usb {
> > +        dr_mode = "host";
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        hub: hub@1 {
> > +            compatible = "usb5e3,608";
> > +            reg = <1>;
> > +            reset-gpios = <&pio 7 2>;
> 
> Use GPIO flags. What did you fix in the example?

It used to be here, but using it needs another include, which I don't
think it necessary here.

Maybe I should just drop this line in the example?

> 
> 
> 
> Best regards,
> Krzysztof
>