Re: [PATCH] trace: Fix some checker warnings

[Steven Rostedt]

On Mon, 5 Dec 2022 12:29:48 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> No, that including defined(CONFIG_FSNOTIFY) :)

Ah I missed that :-)

> 
> So it must be something like 
> 
>   #if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
>           || defined(CONFIG_OSNOISE_TRACER)
>   #define USE_MAX_TRACE_OPS
>   #endif
> 
>   #if defined(USE_MAX_TRACE_OPS) && defined(CONFIG_FSNOTIFY)
>   #define LATENCY_FS_NOTIFY
>   #endif
> 
> 
> But this introduces a hidden dependency which is not tracked by
> kconfig. So I think it is better to make those kconfig (non-menu)

Right, that could be done.

> items. (and the question came up, why can't those use (depend on)
> CONFIG_TRACER_MAX_TRACE instead of introducing the USE_MAX_TRACE_OPS.)

Probably just have OSNOISE and HWLAT select TRACER_MAX_TRACE and just
use that.

-- Steve