Re: [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator

[David Howells]

Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:

> If this is going to be a general replacement for iov_iter_get_pages()
> it's going to need to pass through gup_flags. My recent patchset added
> versions with these and I think it should be in during the next merge
> cycle. [1]

Cool.  Note that the current iov_iter_get_pages2() is broken, which is why Al
wanted a replacement.  It should not be taking a ref on the pages in an
XARRAY, BVEC or PIPE - and it should be pinning rather than getting a ref on
pages in IOVEC or UBUF if the buffer is being read into.  I'm guessing that
your changes move the latter decision to the caller?

David