Re: [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default

From: Rafael J. Wysocki
Date: Wed Dec 07 2022 - 09:39:23 EST


On Wed, Dec 7, 2022 at 1:41 PM <lirongqing@xxxxxxxxx> wrote:
>
> From: Li RongQing <lirongqing@xxxxxxxxx>
>
> Allow user to unload it in running

Just like that? And corrupt things left and right while at it?

No way.

And why do you need this?

> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> ---
> drivers/cpuidle/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
> index ff71dd6..43ddb84 100644
> --- a/drivers/cpuidle/Kconfig
> +++ b/drivers/cpuidle/Kconfig
> @@ -74,7 +74,7 @@ endmenu
> config HALTPOLL_CPUIDLE
> tristate "Halt poll cpuidle driver"
> depends on X86 && KVM_GUEST
> - default y
> + default m
> help
> This option enables halt poll cpuidle driver, which allows to poll
> before halting in the guest (more efficient than polling in the
> --