RE: [PATCH 2/2][v2] cpuidle-haltpoll: Build as module by default
From: Li,Rongqing
Date: Wed Dec 07 2022 - 21:33:50 EST
> > Allow user to unload it in running
>
> Just like that? And corrupt things left and right while at it?
>
> No way.
>
> And why do you need this?
Cpuidle-haltpoll can not improve performance for all cases, like when guest has mwait, unixbench shows a small performance drop;
So change it as module, user can insmod this drivers and rmmod this driver at run time
And some downstream os, centos and ubuntu build it module
Of cause, it will cause performance drop since it is not installed by default, but user insmod this module, this performance can restore, so I think this is acceptable
If this reasom is acceptable, I will add v3; or drop this patch.
Thanks
-Li